petsc Adhere to @AGENTS.md while reviewing and drafting comments.
Identify and fetch
Follow @../review-mr/identify.md (Sections 1–2) to fetch the merge request, check for drift, and repeat its warnings.
Review
Follow @../review-mr/review-procedure.md (Sections 3–5) to read the diff, classify findings, verify each one, compose report. Then continue below to filter and post.
6. Write report
Always write the report (with a title) to ai-review.html! Add a footnote with claude version and model used, the effort level (read from $CLAUDE_EFFORT), date, time, MR_IID, CI_PIPELINE_ID, CI_JOB_ID, when available.
7. Filter findings
Only post findings that have a concrete, actionable fix (a code change the author can apply). Do NOT post:
- Informational or observational notes ("just noting...", "no issue, but...")
- Findings that acknowledge correctness but flag theoretical fragility
- Style nits with no specific suggested change
- Comments on code that was not changed in the MR (surrounding context is for understanding, not reviewing)
Each posted comment opens a discussion thread the author must resolve — avoid noise.
8. Line number mapping
Each comment anchors to line, the line number in the new version of the file.
- For new files: the line number in the file itself.
- For modified files: parse the
@@hunk headers inDIFF_FILEto map correctly. - Only comment on lines that are part of the MR diff. Do not comment on unchanged code that happens to be near the diff.
9. Use GitLab suggestion blocks for concrete fixes
When a comment has a specific code fix, end the body with a suggestion block so the author can click "Apply suggestion":
```suggestion:-0+0
corrected line here
```
-0+0means replace just the target line (thelinein the finding). Use-N+Mto expand the range to N lines before and M lines after the target line.- CRITICAL: The suggestion body replaces the entire selected range. You MUST reproduce every line in the range, not just the changed ones. For example,
suggestion:-2+0selects 3 lines (2 before + the target); the body must contain all 3 lines (with your edits applied). Omitting unchanged lines will delete them. When in doubt, prefersuggestion:-0+0targeting a single line. - To insert a new line after the target, use
suggestion:-0+0and include both the original target line and the new line. - To delete a line, use an empty suggestion block.
- Only use suggestions for concrete fixes. Use plain comments for design/architectural feedback.
10. Post inline comments as DiffNotes
Write the findings to mr-<MR_IID>-findings.json as a list of objects, each with file (the new-side path in the MR diff — the b/ path of its diff --git header, even where the file is renamed), line (Section 8) and body (Section 9):
[
{"file": "src/ts/interface/ts.c", "line": 412, "body": "Missing `PetscCall()`.\n\n```suggestion:-0+0\n PetscCall(TSSetUp(ts));\n```"}
]
Then run python3 lib/petsc/bin/maint/ai_review_post.py <MR_IID> mr-<MR_IID>-findings.json as a single shell command (path relative to the repository root; write the findings file there too, so CI collects it). It anchors every comment to the diff_refs in mr-<MR_IID>-meta.json, demotes suggestion blocks GitLab would render incorrectly, and confirms each response is a DiffNote. Add --dry-run to validate the findings file without posting. A non-zero exit with no POSTED line means nothing was posted; fix the reported problem and rerun. A non-zero exit after one or more POSTED lines means only some findings posted; do not re-run the script — the comments that did post would duplicate. Report per Section 11.
11. Verify
- Report
POSTED_OKandPOSTED_FAILED, and quote everyFAILEDline.