PR Review Workflow
Review pull requests with correct AQE scope boundaries, clear communication, and actionable feedback.
Arguments
<pr-number> — GitHub PR number to review. If omitted, prompt the user.
Steps
1. Read the Full Diff
gh pr diff <pr-number>
gh pr view <pr-number>
Read the complete diff and PR description. Do not skim — read every changed file.
2. Scope Check
- Only analyze AQE/QE skills (NOT Claude Flow platform skills)
- Platform skills to EXCLUDE: v3-, flow-nexus-, agentdb-, reasoningbank-, swarm-, github-, hive-mind-advanced, hooks-automation, iterative-loop, stream-chain, skill-builder, sparc-methodology, pair-programming, release, debug-loop
- If the PR touches skills, verify the count/scope matches expectations (~82 AQE skills)
- Flag any platform skill changes that may have leaked into an AQE-focused PR
3. Summarize Changes
Write a user-friendly summary of what changed and why:
- Focus on outcomes, not implementation details
- Avoid overly technical jargon
- Keep it to 3-5 bullet points
4. Trust Tier Validation
For any skill changes, validate trust_tier assignments:
- tier 3 = has eval infrastructure (evals/, schemas/, scripts/)
- tier 2 = tested but no eval framework
- tier 1 = untested
- Flag inconsistencies (e.g., a skill with evals at tier 2 should be tier 3)
5. Code Quality Review
Check for:
- Hardcoded version strings
- Production safety concerns (adapter changes, breaking changes)
- Missing test coverage for new code
- Security issues (exposed secrets, injection risks)
6. Post Review
gh pr review <pr-number> --body "review comments"
Communication Rules
- Keep tone constructive and actionable
- Be outcome-focused: what should the author do, not what's wrong
- Group related comments together instead of posting many small ones
- If approving with minor suggestions, use APPROVE with comments, not REQUEST_CHANGES
1---2name: pr-review3description: Use when reviewing a GitHub PR for quality, scope correctness, trust tier compliance, or generating user-friendly review feedback.4---5
6# PR Review Workflow
7
8Review pull requests with correct AQE scope boundaries, clear communication, and actionable feedback.
9
10## Arguments
11
12- `<pr-number>` — GitHub PR number to review. If omitted, prompt the user.
13
14## Steps
15
16### 1. Read the Full Diff
17```bash
18gh pr diff <pr-number>
19gh pr view <pr-number>
20```
21Read the complete diff and PR description. Do not skim — read every changed file.
22
23### 2. Scope Check
24- Only analyze AQE/QE skills (NOT Claude Flow platform skills)
25- Platform skills to EXCLUDE: v3-*, flow-nexus-*, agentdb-*, reasoningbank-*, swarm-*, github-*, hive-mind-advanced, hooks-automation, iterative-loop, stream-chain, skill-builder, sparc-methodology, pair-programming, release, debug-loop
26- If the PR touches skills, verify the count/scope matches expectations (~82 AQE skills)
27- Flag any platform skill changes that may have leaked into an AQE-focused PR
28
29### 3. Summarize Changes
30Write a user-friendly summary of what changed and why:
31- Focus on outcomes, not implementation details
32- Avoid overly technical jargon
33- Keep it to 3-5 bullet points
34
35### 4. Trust Tier Validation
36For any skill changes, validate trust_tier assignments:
37- **tier 3** = has eval infrastructure (evals/, schemas/, scripts/)
38- **tier 2** = tested but no eval framework
39- **tier 1** = untested
40- Flag inconsistencies (e.g., a skill with evals at tier 2 should be tier 3)
41
42### 5. Code Quality Review
43Check for:
44- Hardcoded version strings
45- Production safety concerns (adapter changes, breaking changes)
46- Missing test coverage for new code
47- Security issues (exposed secrets, injection risks)
48
49### 6. Post Review
50```bash
51gh pr review <pr-number> --body "review comments"
52```
53
54## Communication Rules
55
56- Keep tone constructive and actionable
57- Be outcome-focused: what should the author do, not what's wrong
58- Group related comments together instead of posting many small ones
59- If approving with minor suggestions, use APPROVE with comments, not REQUEST_CHANGES
proffesor-for-testing