ADR Review
Multi-agent debate pattern for rigorous ADR validation. Orchestrates 6 specialized agents through structured review rounds until consensus or 10 rounds maximum.
Triggers
| Trigger Phrase |
Operation |
review this ADR |
Full 6-agent debate on specified ADR |
validate ADR-005 |
Targeted review of specific ADR by number |
review this decision record |
ADR review for durable architecture/design decision records |
delete ADR-NNN |
Deletion review with dependency and supersession checks |
ADR file created, modified, or deleted |
Auto-triggered via detect_adr_changes.py |
Quick Start
# Manual triggers:
/adr-review .agents/architecture/ADR-005-api-versioning.md
"review this ADR"
"validate ADR-005"
"review this decision record under docs/decisions"
Automatic Detection: A Claude Code hook runs at session start and detects ADR changes, prompting you to invoke this skill. The pre-commit hook also detects staged ADR files and displays a reminder.
| Input |
Output |
Consensus Required |
| ADR file path |
Debate log + Updated ADR |
6/6 Accept or D&C |
File Triggers
| Pattern |
Location |
Events |
ADR-*.md |
.agents/architecture/ |
create, update, delete |
ADR-*.md |
docs/adr/ |
create, update, delete |
ADR-*.md |
docs/architecture/ |
create, update, delete |
ADR-*.md |
docs/decisions/ |
create, update, delete |
ADR-*.md |
architecture/decisions/ |
create, update, delete |
Detection: from the skill directory, run python3 scripts/detect_adr_changes.py --base-path <repo-root>. From repo root, run .claude/skills/adr-review/scripts/detect_adr_changes.py for the Claude skill tree or src/copilot-cli/skills/adr-review/scripts/detect_adr_changes.py for the Copilot CLI mirror.
When to Use
MANDATORY Triggers (automatic):
- Architect creates or updates an ADR
- ANY agent modifies
.agents/architecture/ADR-*.md, docs/adr/ADR-*.md, docs/architecture/ADR-*.md, docs/decisions/ADR-*.md, or architecture/decisions/ADR-*.md
User-Initiated Triggers (manual):
- User requests ADR review ("review this ADR", "validate this decision")
- User asks to review a durable design decision record or rationale for future maintainers
- User requests multi-perspective validation for strategic decisions
Agent Roles
| Agent |
Focus |
Tie-Breaker Role |
| architect |
Structure, governance, coherence, ADR compliance |
Structural questions |
| critic |
Gaps, risks, alignment, completeness |
None |
| independent-thinker |
Challenge assumptions, surface contrarian views |
None |
| security |
Threat models, security trade-offs |
None |
| analyst |
Root cause, evidence, feasibility |
None |
| high-level-advisor |
Priority, resolve conflicts, break ties |
Decision paralysis |
Process
| Phase |
Purpose |
Details |
| Phase 0 |
Related work research |
Search issues/PRs for context |
| Phase 1 |
Independent review |
Each agent reviews ADR using Zimmermann 7-question checklist |
| Phase 2 |
Consolidation |
Identify consensus and conflicts; flag review anti-patterns |
| Phase 3 |
Resolution |
Propose updates for P0/P1 issues |
| Phase 4 |
Convergence check |
Agents vote: Accept/D&C/Block |
Consensus: All 6 agents Accept OR Disagree-and-Commit. Max 10 rounds.
See references/debate-protocol.md for full phase details.
Deletion Workflow
| Phase |
Purpose |
| D1 |
Detection - identify deleted ADR |
| D2 |
Impact assessment - find dependencies |
| D3 |
Archival decision - archive accepted ADRs |
| D4 |
Cleanup - update references |
See references/deletion-workflow.md for full workflow.
Issue Resolution
| Priority |
Requirement |
Gate |
| P0 |
Must resolve |
BLOCKING |
| P1 |
Resolve OR defer with issue |
BLOCKING |
| P2 |
Document |
Non-blocking |
See references/issue-resolution.md for deferral protocol.
Phase 4: Strategic Review (Principal-Level Validation)
After structural and technical review, apply strategic lenses:
Strategic Validation Checklist
Chesterton's Fence (Change Justification)
Path Dependence (Irreversibility Recognition)
Core vs Context (Investment Prioritization)
Second-System Effect (Over-Engineering Detection)
Strategic Review Verdict
Overall Strategic Assessment: [APPROVED | CONCERNS | REJECTED]
Blocking Issues:
- [Strategic issue 1 with required mitigation]
- [Strategic issue 2 with required mitigation]
Recommendations:
- [Strategic improvement 1]
- [Strategic improvement 2]
Scripts
| Script |
Purpose |
.claude/skills/adr-review/scripts/detect_adr_changes.py |
Detect ADR file changes for the Claude skill tree |
src/copilot-cli/skills/adr-review/scripts/detect_adr_changes.py |
Detect ADR file changes for the Copilot CLI mirror |
# Basic detection from repo root
uv run python .claude/skills/adr-review/scripts/detect_adr_changes.py
# Skill-relative detection from the Claude skill directory
cd .claude/skills/adr-review
python3 scripts/detect_adr_changes.py --base-path ../../..
cd ../../..
# Compare to specific commit
uv run python .claude/skills/adr-review/scripts/detect_adr_changes.py --since-commit abc123
# Include untracked ADR files
uv run python .claude/skills/adr-review/scripts/detect_adr_changes.py --include-untracked
# Copilot CLI mirror from repo root
uv run python src/copilot-cli/skills/adr-review/scripts/detect_adr_changes.py --include-untracked
# Skill-relative detection from the Copilot CLI mirror
cd src/copilot-cli/skills/adr-review
python3 scripts/detect_adr_changes.py --base-path ../../../..
cd ../../../..
Verification Checklist
Before marking complete, run the bundled detector to check for pending ADR changes:
uv run python .claude/skills/adr-review/scripts/detect_adr_changes.py --include-untracked
echo "exit=$?" # must be 0; non-zero means git error or I/O failure
After skill invocation:
Anti-Patterns
Process Anti-Patterns
| Avoid |
Why |
Instead |
| Single-agent ADR review |
Misses domain expertise |
Use full 6-agent debate |
| Skipping Phase 0 |
Duplicates existing work |
Always research first |
| Ignoring D&C dissent |
Loses important context |
Document all reservations |
| Manual ADR monitoring |
Error-prone |
Use detect_adr_changes.py |
| Deleting accepted ADRs without archive |
Loses knowledge |
Always archive accepted ADRs |
Review Anti-Patterns (Zimmermann)
Each agent should self-check against these. Phase 2 consolidation flags violations.
| Anti-Pattern |
Problem |
Detection |
| Pass Through |
Few/no comments, document barely read |
Agent produces no substantive findings |
| Copy Edit |
Focuses on wording, ignores content |
All findings editorial, none architectural |
| Siding/Dead End |
Comments switch topic, deviate from ADR |
Agent drifts from decision at hand |
| Self Promotion |
Recommends reviewer's preferred solution |
Agent pushes technology without objective rationale |
| Power Game |
Authority claims instead of technical arguments |
Agent uses position over evidence |
| Offended Reaction |
Defends criticized position subjectively |
Agent reacts emotionally to rationale |
| Groundhog Day |
Same message repeated across rounds |
Agent re-raises resolved issues |
See zimmermann-review-guidance.md for full practices and pledges.
References
| Document |
Content |
| debate-protocol.md |
Full Phases 0-4 workflow |
| deletion-workflow.md |
Phases D1-D4 workflow |
| issue-resolution.md |
P0/P1/P2 handling and deferral |
| artifacts.md |
Output formats and templates |
| agent-prompts.md |
Detailed agent prompt templates |
| zimmermann-review-guidance.md |
Review practices, 7 anti-patterns, checklist, reviewer pledge (Zimmermann 2023) |
1---2name: adr-review3version: 1.1.04description: Multi-agent debate orchestration for Architecture Decision Records. Automatically triggers on ADR create/edit/delete. Coordinates architect, critic, independent-thinker, security, analyst, and high-level-advisor agents in structured debate rounds until consensus. Use when you say "review this ADR", when an ADR is created/edited/deleted, or when reviewing, accepting, or updating a decision file under .agents/architecture/, docs/architecture/, docs/decisions/, docs/adr/, or architecture/decisions/, including intent like "review this decision record" or "check this rationale for future maintainers". Do NOT use to author a new ADR (use adr-generator).5license: MIT6metadata:7 source: https://skillmd.com/skills/rjmurillo/adr-review8 domains: [architecture, governance, multi-agent, consensus]9 type: orchestrator10 inputs: [adr-file-path, change-type]11 outputs: [debate-log, updated-adr, recommendations]12 file_triggers:13 patterns:14 - ".agents/architecture/ADR-*.md"15 - "docs/adr/ADR-*.md"16 - "docs/architecture/ADR-*.md"17 - "docs/decisions/ADR-*.md"18 - "architecture/decisions/ADR-*.md"19 events: [create, update, delete]20 auto_invoke: true21---2223# ADR Review2425Multi-agent debate pattern for rigorous ADR validation. Orchestrates 6 specialized agents through structured review rounds until consensus or 10 rounds maximum.2627## Triggers2829| Trigger Phrase | Operation |30|----------------|-----------|31| `review this ADR` | Full 6-agent debate on specified ADR |32| `validate ADR-005` | Targeted review of specific ADR by number |33| `review this decision record` | ADR review for durable architecture/design decision records |34| `delete ADR-NNN` | Deletion review with dependency and supersession checks |35| `ADR file created, modified, or deleted` | Auto-triggered via detect_adr_changes.py |3637---3839## Quick Start4041```text42# Manual triggers:43/adr-review .agents/architecture/ADR-005-api-versioning.md44"review this ADR"45"validate ADR-005"46"review this decision record under docs/decisions"47```4849**Automatic Detection**: A Claude Code hook runs at session start and detects ADR changes, prompting you to invoke this skill. The pre-commit hook also detects staged ADR files and displays a reminder.5051| Input | Output | Consensus Required |52|-------|--------|-------------------|53| ADR file path | Debate log + Updated ADR | 6/6 Accept or D&C |5455## File Triggers5657| Pattern | Location | Events |58|---------|----------|--------|59| `ADR-*.md` | `.agents/architecture/` | create, update, delete |60| `ADR-*.md` | `docs/adr/` | create, update, delete |61| `ADR-*.md` | `docs/architecture/` | create, update, delete |62| `ADR-*.md` | `docs/decisions/` | create, update, delete |63| `ADR-*.md` | `architecture/decisions/` | create, update, delete |6465**Detection**: from the skill directory, run `python3 scripts/detect_adr_changes.py --base-path <repo-root>`. From repo root, run `.claude/skills/adr-review/scripts/detect_adr_changes.py` for the Claude skill tree or `src/copilot-cli/skills/adr-review/scripts/detect_adr_changes.py` for the Copilot CLI mirror.6667## When to Use6869**MANDATORY Triggers** (automatic):7071- Architect creates or updates an ADR72- ANY agent modifies `.agents/architecture/ADR-*.md`, `docs/adr/ADR-*.md`, `docs/architecture/ADR-*.md`, `docs/decisions/ADR-*.md`, or `architecture/decisions/ADR-*.md`7374**User-Initiated Triggers** (manual):7576- User requests ADR review ("review this ADR", "validate this decision")77- User asks to review a durable design decision record or rationale for future maintainers78- User requests multi-perspective validation for strategic decisions7980## Agent Roles8182| Agent | Focus | Tie-Breaker Role |83|-------|-------|------------------|84| **architect** | Structure, governance, coherence, ADR compliance | Structural questions |85| **critic** | Gaps, risks, alignment, completeness | None |86| **independent-thinker** | Challenge assumptions, surface contrarian views | None |87| **security** | Threat models, security trade-offs | None |88| **analyst** | Root cause, evidence, feasibility | None |89| **high-level-advisor** | Priority, resolve conflicts, break ties | Decision paralysis |9091## Process9293| Phase | Purpose | Details |94|-------|---------|---------|95| **Phase 0** | Related work research | Search issues/PRs for context |96| **Phase 1** | Independent review | Each agent reviews ADR using [Zimmermann 7-question checklist](references/zimmermann-review-guidance.md) |97| **Phase 2** | Consolidation | Identify consensus and conflicts; flag [review anti-patterns](references/zimmermann-review-guidance.md) |98| **Phase 3** | Resolution | Propose updates for P0/P1 issues |99| **Phase 4** | Convergence check | Agents vote: Accept/D&C/Block |100101**Consensus**: All 6 agents Accept OR Disagree-and-Commit. Max 10 rounds.102103See [references/debate-protocol.md](references/debate-protocol.md) for full phase details.104105## Deletion Workflow106107| Phase | Purpose |108|-------|---------|109| **D1** | Detection - identify deleted ADR |110| **D2** | Impact assessment - find dependencies |111| **D3** | Archival decision - archive accepted ADRs |112| **D4** | Cleanup - update references |113114See [references/deletion-workflow.md](references/deletion-workflow.md) for full workflow.115116## Issue Resolution117118| Priority | Requirement | Gate |119|----------|-------------|------|120| **P0** | Must resolve | BLOCKING |121| **P1** | Resolve OR defer with issue | BLOCKING |122| **P2** | Document | Non-blocking |123124See [references/issue-resolution.md](references/issue-resolution.md) for deferral protocol.125126## Phase 4: Strategic Review (Principal-Level Validation)127128After structural and technical review, apply strategic lenses:129130### Strategic Validation Checklist131132#### Chesterton's Fence (Change Justification)133134- [ ] If removing/changing existing patterns: Original purpose documented135- [ ] Investigation evidence provided (git archaeology, interviews, documentation)136- [ ] Confirmation original problem no longer exists137- [ ] Assessment: [PASS | FAIL | N/A]138139#### Path Dependence (Irreversibility Recognition)140141- [ ] Historical constraints identified and documented142- [ ] Reversibility assessment complete (rollback capability, vendor lock-in)143- [ ] Migration/exit strategy defined if adding dependencies144- [ ] Irreversible decisions explicitly flagged and justified145- [ ] Assessment: [PASS | FAIL | N/A]146147#### Core vs Context (Investment Prioritization)148149- [ ] Capability classified as Core (differentiating) or Context (commodity)150- [ ] If building Context: Justification for not buying/outsourcing151- [ ] If Core: Competitive differentiation explained152- [ ] Assessment: [PASS | FAIL | N/A]153154#### Second-System Effect (Over-Engineering Detection)155156- [ ] If replacing existing system: Scope boundaries explicit157- [ ] Feature list justified (not "everything we didn't do last time")158- [ ] Simplicity preservation strategy documented159- [ ] Assessment: [PASS | FAIL | N/A]160161### Strategic Review Verdict162163**Overall Strategic Assessment**: [APPROVED | CONCERNS | REJECTED]164165**Blocking Issues**:166167- [Strategic issue 1 with required mitigation]168- [Strategic issue 2 with required mitigation]169170**Recommendations**:171172- [Strategic improvement 1]173- [Strategic improvement 2]174175## Scripts176177| Script | Purpose |178|--------|---------|179| `.claude/skills/adr-review/scripts/detect_adr_changes.py` | Detect ADR file changes for the Claude skill tree |180| `src/copilot-cli/skills/adr-review/scripts/detect_adr_changes.py` | Detect ADR file changes for the Copilot CLI mirror |181182```bash183# Basic detection from repo root184uv run python .claude/skills/adr-review/scripts/detect_adr_changes.py185186# Skill-relative detection from the Claude skill directory187cd .claude/skills/adr-review188python3 scripts/detect_adr_changes.py --base-path ../../..189cd ../../..190191# Compare to specific commit192uv run python .claude/skills/adr-review/scripts/detect_adr_changes.py --since-commit abc123193194# Include untracked ADR files195uv run python .claude/skills/adr-review/scripts/detect_adr_changes.py --include-untracked196197# Copilot CLI mirror from repo root198uv run python src/copilot-cli/skills/adr-review/scripts/detect_adr_changes.py --include-untracked199200# Skill-relative detection from the Copilot CLI mirror201cd src/copilot-cli/skills/adr-review202python3 scripts/detect_adr_changes.py --base-path ../../../..203cd ../../../..204```205206## Verification Checklist207208Before marking complete, run the bundled detector to check for pending ADR changes:209210```bash211uv run python .claude/skills/adr-review/scripts/detect_adr_changes.py --include-untracked212echo "exit=$?" # must be 0; non-zero means git error or I/O failure213```214215- [ ] The detector script exited 0 (no git or I/O errors)216- [ ] If skill was auto-triggered by a file change, `HasChanges` should be `true`; if skill was manually invoked on an existing committed ADR, `HasChanges: false` is expected and acceptable217218After skill invocation:219220- [ ] Debate log exists at `.agents/critique/ADR-NNN-debate-log.md`221- [ ] ADR status updated using the frontmatter enum below; use prose for review nuance222- [ ] Frontmatter `status` field present and a valid enum value: one of223 `proposed | accepted | rejected | deprecated | superseded` (ADR-073).224 A missing or out-of-enum `status` is a P1 blocker; the frontmatter enum is225 authoritative for tooling, the prose `## Status` carries the human nuance.226- [ ] If this review transitions `status` to `accepted`: the same change carries227 adr-review debate-log evidence at `.agents/critique/ADR-NNN-debate-log.md`228 (ADR-073 Phase-3 acceptance gate). A hand-edit to `accepted` with no229 debate-log artifact is a forgeable approval signal and MUST be rejected.230<!-- vendor-portability: declared. adr-review checks accepted-transition evidence under .agents/critique/; a consumer repo without it reports missing evidence, not a silent pass. Issue #2050. -->231- [ ] All P0 issues addressed or documented232- [ ] Dissent captured for Disagree-and-Commit positions233- [ ] Recommendations provided to orchestrator234235## Anti-Patterns236237### Process Anti-Patterns238239| Avoid | Why | Instead |240|-------|-----|---------|241| Single-agent ADR review | Misses domain expertise | Use full 6-agent debate |242| Skipping Phase 0 | Duplicates existing work | Always research first |243| Ignoring D&C dissent | Loses important context | Document all reservations |244| Manual ADR monitoring | Error-prone | Use detect_adr_changes.py |245| Deleting accepted ADRs without archive | Loses knowledge | Always archive accepted ADRs |246247### Review Anti-Patterns (Zimmermann)248249Each agent should self-check against these. Phase 2 consolidation flags violations.250251| Anti-Pattern | Problem | Detection |252|-------------|---------|-----------|253| **Pass Through** | Few/no comments, document barely read | Agent produces no substantive findings |254| **Copy Edit** | Focuses on wording, ignores content | All findings editorial, none architectural |255| **Siding/Dead End** | Comments switch topic, deviate from ADR | Agent drifts from decision at hand |256| **Self Promotion** | Recommends reviewer's preferred solution | Agent pushes technology without objective rationale |257| **Power Game** | Authority claims instead of technical arguments | Agent uses position over evidence |258| **Offended Reaction** | Defends criticized position subjectively | Agent reacts emotionally to rationale |259| **Groundhog Day** | Same message repeated across rounds | Agent re-raises resolved issues |260261See [zimmermann-review-guidance.md](references/zimmermann-review-guidance.md) for full practices and pledges.262263## References264265| Document | Content |266|----------|---------|267| [debate-protocol.md](references/debate-protocol.md) | Full Phases 0-4 workflow |268| [deletion-workflow.md](references/deletion-workflow.md) | Phases D1-D4 workflow |269| [issue-resolution.md](references/issue-resolution.md) | P0/P1/P2 handling and deferral |270| [artifacts.md](references/artifacts.md) | Output formats and templates |271| [agent-prompts.md](references/agent-prompts.md) | Detailed agent prompt templates |272| [zimmermann-review-guidance.md](references/zimmermann-review-guidance.md) | Review practices, 7 anti-patterns, checklist, reviewer pledge (Zimmermann 2023) |