RFC Review Skill
Review a technical RFC across structured perspectives and produce a written review report. The aim is a coherent, opinionated review that catches the issues a careful reviewer would, not a generic checklist pass.
Usage
/rfc-review # Find the RFC on the current branch and review it
/rfc-review docs/rfcs/my-rfc.md # Review a specific RFC file
/rfc-review --focus compat # Drill into one lens (see lens list below)
/rfc-review --brief # Top-line verdict + major concerns only
When to invoke this skill
- The user asks for an RFC, design doc, ADR, or proposal review.
- The user is on a branch whose primary content is an RFC document (e.g. recent commit titled "RFC for ...").
- The user asks "what do you think of this design" about a document, not code.
Do NOT invoke for implementation PR review — use /review instead. RFCs propose, code implements; the lenses differ.
Workflow
Step 1 — Locate the RFC
In order of preference:
- Argument path, if provided.
- PR/branch context: run
git log -1 --name-only and look for added/modified .md files under docs/, rfcs/, design/, or paths matching *rfc*.
- If still ambiguous, ask the user for the path. Do not guess across multiple candidates.
Step 2 — Read the RFC and its context
- Read the full RFC document. Do not skim.
- Follow links to referenced specs, prior RFCs, and code paths it claims to touch. If a path is named, confirm it exists with Glob/Grep.
- Note the author, status (draft/proposed/accepted), and any prior review comments visible on the PR.
Step 3 — Walk the lenses
See prompt.md for the full per-lens checklist. The umbrella lens set:
- Framing — Problem clarity, alternatives considered, non-goals.
- Design correctness — Technical soundness, interface design, architectural fit.
- Change management — Compatibility, migration/rollout, blast radius.
- Operational — Performance, testing strategy, build/packaging/CI, observability, security.
- Sustainability — Maintenance cost, ownership, documentation.
- RFC as document — Internal consistency, named risks, stakeholder coverage.
For each lens, produce: strengths, concerns (graded blocking / non-blocking), and questions for the author. If a lens does not apply (e.g. no public API surface → skip API ergonomics), say so explicitly rather than padding.
Step 4 — Ask the user how to deliver the report
Before writing, ask the user how they want the report delivered. Offer these options:
- On disk next to the RFC — saved as
<rfc-dir>/review-<YYYY-MM-DD>-<reviewer>.md. Best for sharing or attaching to a PR.
- Inline in chat only — printed in the conversation, nothing written to disk. Best for quick iteration.
- Both — written to disk and printed inline.
Skip this prompt only if the user already stated a preference in this turn (e.g. "just print it" or "save the review to ..."), in which case respect that and note the choice in your reply.
Step 5 — Synthesize the report
Use assets/templates/review-report.md as the structure. Lead with the verdict and blocking concerns; put per-lens detail underneath so the author can skim or drill in.
If writing to disk, use the git user name (git config user.name) as <reviewer> and tell the user the path when done.
Step 6 — Recommend follow-up reviews
If any lens warrants deeper specialized review, name it explicitly at the end of the report:
- Cross-version / ABI concerns →
/rfc-review-compatibility (focused skill)
- Build, CI, packaging, observability →
/rfc-review-ops (focused skill)
- Threat model, attack surface →
/rfc-review-security (focused skill)
Recommend a focused pass only when the umbrella surfaced enough signal to warrant it — don't reflexively list all three on every review.
Output rules
- No padding. A lens with nothing to say should be one line: "Framing — no concerns." Do not invent issues to fill a section.
- Cite the RFC. Every concern should quote or reference the specific section/line it pertains to, so the author can find it.
- Separate blocking from non-blocking. A blocking concern means "I would not approve without this resolved." Use the label sparingly.
- Ask, don't assert. When a section is ambiguous, ask a question rather than guess what the author meant and critique the guess.
- Verdict at the top. One of:
approve, approve-with-comments, needs-revision, block. Justify in one sentence.
Examples
/rfc-review
# → finds MIOpen-hipDNN shim RFC on current branch, produces full review
/rfc-review docs/rfcs/0042-new-allocator.md --brief
# → verdict + blocking concerns only, no per-lens detail
/rfc-review --focus compat
# → only the compatibility/migration lens, in depth
1---2name: rfc-review3description: Review a technical RFC or design document across a structured set of perspectives (framing, design correctness, change management, operational concerns, sustainability) and produce a written review report. Use when reviewing RFCs, design docs, ADRs, or proposal documents — not for reviewing implementation PRs (use /review for that).4argument-hint: "[<path-or-pr>] [--focus <lens>] [--brief]"5allowed-tools: Read, Grep, Glob, Bash, WebFetch6metadata:7 source: https://skillmd.com/skills/rocm/rfc-review8---910# RFC Review Skill1112Review a technical RFC across structured perspectives and produce a written review report. The aim is a coherent, opinionated review that catches the issues a careful reviewer would, not a generic checklist pass.1314## Usage1516```17/rfc-review # Find the RFC on the current branch and review it18/rfc-review docs/rfcs/my-rfc.md # Review a specific RFC file19/rfc-review --focus compat # Drill into one lens (see lens list below)20/rfc-review --brief # Top-line verdict + major concerns only21```2223## When to invoke this skill2425- The user asks for an RFC, design doc, ADR, or proposal review.26- The user is on a branch whose primary content is an RFC document (e.g. recent commit titled "RFC for ...").27- The user asks "what do you think of this design" about a document, not code.2829Do NOT invoke for implementation PR review — use `/review` instead. RFCs propose, code implements; the lenses differ.3031## Workflow3233### Step 1 — Locate the RFC3435In order of preference:361. Argument path, if provided.372. PR/branch context: run `git log -1 --name-only` and look for added/modified `.md` files under `docs/`, `rfcs/`, `design/`, or paths matching `*rfc*`.383. If still ambiguous, ask the user for the path. Do not guess across multiple candidates.3940### Step 2 — Read the RFC and its context4142- Read the full RFC document. Do not skim.43- Follow links to referenced specs, prior RFCs, and code paths it claims to touch. If a path is named, confirm it exists with Glob/Grep.44- Note the author, status (draft/proposed/accepted), and any prior review comments visible on the PR.4546### Step 3 — Walk the lenses4748See `prompt.md` for the full per-lens checklist. The umbrella lens set:49501. **Framing** — Problem clarity, alternatives considered, non-goals.512. **Design correctness** — Technical soundness, interface design, architectural fit.523. **Change management** — Compatibility, migration/rollout, blast radius.534. **Operational** — Performance, testing strategy, build/packaging/CI, observability, security.545. **Sustainability** — Maintenance cost, ownership, documentation.556. **RFC as document** — Internal consistency, named risks, stakeholder coverage.5657For each lens, produce: **strengths**, **concerns** (graded blocking / non-blocking), and **questions for the author**. If a lens does not apply (e.g. no public API surface → skip API ergonomics), say so explicitly rather than padding.5859### Step 4 — Ask the user how to deliver the report6061Before writing, ask the user how they want the report delivered. Offer these options:62631. **On disk next to the RFC** — saved as `<rfc-dir>/review-<YYYY-MM-DD>-<reviewer>.md`. Best for sharing or attaching to a PR.642. **Inline in chat only** — printed in the conversation, nothing written to disk. Best for quick iteration.653. **Both** — written to disk and printed inline.6667Skip this prompt only if the user already stated a preference in this turn (e.g. "just print it" or "save the review to ..."), in which case respect that and note the choice in your reply.6869### Step 5 — Synthesize the report7071Use `assets/templates/review-report.md` as the structure. Lead with the verdict and blocking concerns; put per-lens detail underneath so the author can skim or drill in.7273If writing to disk, use the git user name (`git config user.name`) as `<reviewer>` and tell the user the path when done.7475### Step 6 — Recommend follow-up reviews7677If any lens warrants deeper specialized review, name it explicitly at the end of the report:7879- Cross-version / ABI concerns → `/rfc-review-compatibility` (focused skill)80- Build, CI, packaging, observability → `/rfc-review-ops` (focused skill)81- Threat model, attack surface → `/rfc-review-security` (focused skill)8283Recommend a focused pass only when the umbrella surfaced enough signal to warrant it — don't reflexively list all three on every review.8485## Output rules8687- **No padding.** A lens with nothing to say should be one line: "Framing — no concerns." Do not invent issues to fill a section.88- **Cite the RFC.** Every concern should quote or reference the specific section/line it pertains to, so the author can find it.89- **Separate blocking from non-blocking.** A blocking concern means "I would not approve without this resolved." Use the label sparingly.90- **Ask, don't assert.** When a section is ambiguous, ask a question rather than guess what the author meant and critique the guess.91- **Verdict at the top.** One of: `approve`, `approve-with-comments`, `needs-revision`, `block`. Justify in one sentence.9293## Examples9495```96/rfc-review97# → finds MIOpen-hipDNN shim RFC on current branch, produces full review9899/rfc-review docs/rfcs/0042-new-allocator.md --brief100# → verdict + blocking concerns only, no per-lens detail101102/rfc-review --focus compat103# → only the compatibility/migration lens, in depth104```