Review

Review code changes with a bug-first, risk-focused workflow before merge or release.

s-hiraoku Updated

File contents

Review

Use this workflow when reviewing a diff, pull request, branch, or local change set.

Workflow

  1. Identify the review scope: diff, files, commit range, pull request, or task goal.
  2. Inspect changed behavior before style or cleanup concerns.
  3. Prioritize bugs, regressions, security risks, data-loss risks, and missing verification.
  4. Check whether tests, docs, migrations, and release notes match the behavioral impact.
  5. Look for edge cases around empty input, permissions, concurrency, rollback, and failure paths.
  6. Keep findings specific, reproducible, and tied to exact files or lines when possible.
  7. Avoid broad refactor suggestions unless they block correctness, safety, or maintainability.
  8. If no issues are found, say so clearly and note remaining test gaps or residual risk.

Final Report

Lead with findings, ordered by severity.

For each finding, include:

  • severity or priority
  • file and line when available
  • what can fail
  • why it matters
  • a concrete fix direction

Then include:

  • open questions or assumptions
  • verification reviewed or still missing
  • brief summary of the reviewed change

s-hiraoku/hakoniwa/tree/main/.claude/skills/review commit 81f8b84149

Frequently asked questions

npx skillmds@latest add s-hiraoku/review-2