Code Review Guide Skill
Bad code review nitpicks style while missing the design flaw, or dumps 40 ungraded comments. Good review is
prioritized and kind: it catches what actually matters (correctness, security, design), separates blocking
issues from nits, explains the why, and leaves the author better. This skill runs that review.
Not quite this? Use code-review-checklist when you only need a checklist tailored to one change; use ai-code-review when most of the change was written by an AI assistant; use infra-as-code-review when the change is Terraform, CloudFormation or other infrastructure code.
Required Inputs
Ask for these only if they aren't already provided:
- The change — the diff/PR, and ideally its description/intent (what it's trying to do).
- Context — language/stack, conventions, the part of the system it touches, risk level.
- Focus (optional) — anything specific to scrutinize (security, performance, a tricky area).
Output Format
Review: [PR / change]
Summary — in 1–2 lines: what the change does and your overall read (solid / needs work / risky).
Review passes — scan in priority order and note findings:
- Correctness — does it do what it claims? Edge cases, error handling, off-by-ones, concurrency.
- Security & data — input validation, authz, secrets, injection, PII handling.
- Design — is this the right approach? Coupling, the seam, simpler alternative, future pain.
- Tests — do they cover the behavior and the edges? Would they catch a regression?
- Readability — names, clarity, dead code, docs where non-obvious.
Comments (ranked by severity) — each with file/line, the issue, why it matters, and a concrete suggestion:
| Severity |
Where |
Comment & why |
Suggested change |
| 🔴 Blocking |
|
|
|
| 🟡 Should-fix |
|
|
|
| 🔵 Nit / optional |
|
|
|
What's done well — genuinely (specific, not flattery). Reviews are also for morale and learning.
Verdict — ✅ Approve / 🔁 Request changes / 💬 Comment — with the one or two things that gate it.
Quality Checks
Anti-Patterns
Based On
Senior code-review practice (Google's engineering review guidelines): prioritize correctness/design, severity-tag feedback, be kind.
Example Trigger Phrases
- "Review code."
- "Give PR feedback."
- "Review this change."
1---2name: code-review-guide3description: "Review a pull request or diff like a thoughtful senior engineer — prioritized, kind, and focused on what matters. Use when reviewing code, giving PR feedback, or asked to 'review this change'. Produces a structured review: a correctness/design pass, comments ranked by severity (blocking → nit), what's done well, and a clear approve / request-changes call — feedback that improves the code and the author."4disable-model-invocation: true # skill-optimizer5metadata:6 source: https://skillmd.com/skills/slipcast-dev/code-review-guide7---89# Code Review Guide Skill1011Bad code review nitpicks style while missing the design flaw, or dumps 40 ungraded comments. Good review is12*prioritized* and *kind*: it catches what actually matters (correctness, security, design), separates blocking13issues from nits, explains the *why*, and leaves the author better. This skill runs that review.1415> **Not quite this?** Use `code-review-checklist` when you only need a checklist tailored to one change; use `ai-code-review` when most of the change was written by an AI assistant; use `infra-as-code-review` when the change is Terraform, CloudFormation or other infrastructure code.1617## Required Inputs1819Ask for these only if they aren't already provided:2021- **The change** — the diff/PR, and ideally its description/intent (what it's trying to do).22- **Context** — language/stack, conventions, the part of the system it touches, risk level.23- **Focus** (optional) — anything specific to scrutinize (security, performance, a tricky area).2425## Output Format2627### Review: [PR / change]2829**Summary** — in 1–2 lines: what the change does and your overall read (solid / needs work / risky).3031**Review passes** — scan in priority order and note findings:321. **Correctness** — does it do what it claims? Edge cases, error handling, off-by-ones, concurrency.332. **Security & data** — input validation, authz, secrets, injection, PII handling.343. **Design** — is this the right approach? Coupling, the seam, simpler alternative, future pain.354. **Tests** — do they cover the behavior and the edges? Would they catch a regression?365. **Readability** — names, clarity, dead code, docs where non-obvious.3738**Comments (ranked by severity)** — each with file/line, the issue, *why* it matters, and a concrete suggestion:3940| Severity | Where | Comment & why | Suggested change |41|---|---|---|---|42| 🔴 Blocking | | | |43| 🟡 Should-fix | | | |44| 🔵 Nit / optional | | | |4546**What's done well** — genuinely (specific, not flattery). Reviews are also for morale and learning.4748**Verdict** — ✅ Approve / 🔁 Request changes / 💬 Comment — with the one or two things that gate it.4950## Quality Checks5152- [ ] Correctness, security, and design are reviewed before style — priority order53- [ ] Comments are ranked by severity (blocking vs. should-fix vs. nit), not a flat list54- [ ] Each comment explains *why* and offers a concrete suggestion, not just "this is wrong"55- [ ] At least one specific thing done well is noted56- [ ] A clear verdict (approve / request changes) with the gating issues named57- [ ] Tone is direct but kind — critiques the code, not the author5859## Anti-Patterns6061- [ ] Do not nitpick style while missing a correctness or security problem — priority first62- [ ] Do not dump ungraded comments — rank them so the author knows what's blocking63- [ ] Do not say "this is wrong" without why and a suggested fix64- [ ] Do not rewrite it your way for taste — respect working approaches; flag real issues65- [ ] Do not be a jerk — review the code, acknowledge good work, keep the author motivated6667## Based On6869Senior code-review practice (Google's engineering review guidelines): prioritize correctness/design, severity-tag feedback, be kind.7071## Example Trigger Phrases7273- "Review code."74- "Give PR feedback."75- "Review this change."