spacedriveapp Review Fix Loop
Goal
Close review rounds with minimal back-and-forth by mapping every finding to a code change and proof.
Execution Loop
- Parse findings into
P1,P2,P3. - Build a closure table before editing.
- Implement the smallest coherent fix batch.
- Run targeted verification.
- Update closure table with outcomes.
- Run broader gate checks.
Closure Table
Use one row per finding:
| Finding | Severity | Owned files | Planned change | Verification command | Result |
|---|
Re-Run Control
- If the same command fails twice, stop rerunning.
- Isolate a smaller reproduction command.
- Patch the smallest likely cause.
- Re-run narrow verification before broad checks.
Verification Ladder
- Start narrow: unit/module behavior checks for touched paths.
- Continue medium: compile/lint/type checks for touched surfaces.
- End broad: repository gate commands.
Handoff Requirements
- Findings closed
- Commands executed
- Pass/fail evidence per finding
- Remaining open findings with rationale
- Residual risk