Benjaminwestern Google Engineer Skills Terraform

Terraform Skill

Comprehensive Terraform guidance covering modules, testing, CI/CD, and production patterns. Combines best practices from terraform-best-practices.com and Cloud Foundation Fabric.

The Seven Mantras

These principles guide all Terraform work:

1. Always Have versions.tf — Every root module must define providers, versions, and configuration. Never leave provider config implicit.
2. Always Have backend.tf — Even if empty initially, you'll need remote state (GCS for GCP).
3. Always Have locals.tf — Centralize all local values, don't scatter them across files.
4. Vertical Files by Domain — Organize by workload (webserver.tf, salesforce-etl.tf), not by resource type (iam.tf, compute.tf).
5. Variables with Sane Defaults — Provide sensible defaults and example tfvars files.
6. YAML Factories for Heavy Reuse — Enable non-Terraform users via YAML configs + factory patterns.
7. Maximize Autonomy — App repos own their resources, foundations repos own shared infrastructure. Avoid cross-repo dependencies.

Core Principles

1. Required Files

Every Terraform root module must have:

2. Vertical File Organization

Organize by domain/workload, not by resource type:

# GOOD - Files by domain:
├── networking.tf      # VPC, subnets, routes, NAT
├── webserver.tf       # MIG, template, LB, service account
├── salesforce-etl.tf  # SA, secrets, Cloud Function, BigQuery
└── database.tf        # Cloud SQL, IAM, backups

# BAD - Files by resource type:
├── iam.tf            # All IAM mixed together
├── compute.tf        # All compute mixed together
└── storage.tf        # All storage mixed together

3. Naming Conventions

4. Module Boundaries

Quick Decision Reference

Count vs For_Each

Do resources need meaningful identifiers?
│
├─ YES → for_each (with set or map)
│
└─ NO → Can items change position?
    ├─ YES → for_each (prevents cascade)
    └─ NO → count (simpler)

See code-patterns.md for migration patterns and detailed examples.

Testing Approach

What do you need to test?
│
├─ Syntax/format? → terraform validate + fmt
├─ Security? → trivy + checkov
├─ Simple logic (1.6+)? → Native tests
└─ Complex integration? → Terratest

See testing-frameworks.md for implementation details.

Authentication (GCP)

Always use OIDC. Never use service account keys.

See security-compliance.md for OIDC setup and security patterns.

Modern Features (Quick Reference)

Essential Commands

# Static analysis (always free)
terraform fmt -recursive -check
terraform validate
tflint
trivy config .
checkov -d .

# Testing (1.6+)
terraform test

# Plan and apply
terraform plan -out=tfplan
terraform apply -auto-approve tfplan

# State management
terraform state list
terraform show

See quick-reference.md for full cheat sheet.

Security Checklist

• Authentication: Using OIDC (not keys)
• Secrets: In Secret Manager (not state/variables)
• Network: Custom VPC (not default)
• Firewall: Least privilege (not 0.0.0.0/0)
• State: Encrypted, versioned, restricted access
• Scanning: Trivy/Checkov in CI/CD

See security-compliance.md for detailed patterns.

Module Checklist

• versions.tf with provider constraints
• backend.tf for remote state
• variables.tf with descriptions and validation
• outputs.tf with descriptions
• examples/ directory (simple and complete)
• Tests (native 1.6+ or Terratest)
• Pre-commit hooks configured
• Documentation in README.md

See module-patterns.md for details.

CI/CD Essentials

Standard Pipeline

validate → plan → apply

Key Decisions

See ci-cd-workflows.md for templates.

Reference Documentation

code-patterns.md

When to use: Writing or refactoring Terraform code

Covers:

• Count vs for_each decision guide and migration patterns
• Block ordering rules (resources, variables)
• Modern features decision guide (try, optional, moved, write-only)
• Version constraints and update strategy
• Secrets management patterns
• Refactoring from legacy (0.12/0.13) to modern syntax

quick-reference.md

When to use: Need quick lookup or troubleshooting

Covers:

• Command cheat sheet (format, validate, test, plan)
• Decision flowcharts (testing, module workflow, refactoring)
• Version-specific guidance (1.0-1.5, 1.6+, 1.7+)
• Troubleshooting common issues
• Version constraint syntax reference

module-patterns.md

When to use: Creating or restructuring modules

Covers:

• Module type decision tree (Resource → Infrastructure → Composition)
• Architecture decisions (scope size, module connections)
• File organization standards
• Parameterization vs hardcoding
• Root module vs reusable module boundaries
• Naming decisions (variables, outputs)
• Anti-patterns to avoid (god modules, environment sprawl)

testing-frameworks.md

When to use: Setting up or choosing testing approach

Covers:

• Testing decision flowchart
• Native tests vs Terratest comparison
• Critical plan vs apply decision
• Working with set-type blocks
• Mocking decisions
• Terratest patterns and cost management
• Testing checklist

ci-cd-workflows.md

When to use: Setting up CI/CD pipelines

Covers:

• Standard validate → plan → apply pipeline
• OIDC authentication patterns
• Apply strategy options (push, approval, comment-triggered)
• Environment organization (separate vs reusable workflows)
• Essential security checks in CI
• Atlantis integration decision guide

security-compliance.md

When to use: Security review or compliance setup

Covers:

• OIDC vs service account key decision
• Secrets management (what's safe vs unsafe)
• Network architecture decisions
• Firewall rule best practices
• State security requirements
• Compliance testing tools (trivy, checkov, terraform-compliance, OPA)

factory-patterns.md

When to use: Building scalable, self-service infrastructure

Covers:

• When to use factory vs traditional modules
• Configuration format decisions (YAML vs JSON)
• Discovery methods (single file vs auto-discovery)
• Default strategy patterns
• Factory patterns by use case (Project, Subnet, Service Account)
• Conditional resource creation
• Lifecycle hooks
• When NOT to use factory pattern

Based on:

• Cloud Foundation Fabric by Google Cloud Platform

Source: benjaminwestern/google-engineer-skills — distributed by TomeVault.