Code Review Skill
Purpose
Provide thorough, constructive code reviews that improve code quality and share knowledge.
Review Focus Areas
1. Correctness
- Does the code do what it claims?
- Are edge cases handled?
- Are there potential bugs?
2. Design
- Is the code well-structured?
- Are abstractions appropriate?
- Does it follow project patterns?
3. Performance
- Are there obvious performance issues?
- Unnecessary loops or allocations?
- Appropriate data structures?
4. Security
- Input validation present?
- Secrets properly handled?
- SQL injection, XSS risks?
5. Maintainability
- Is the code readable?
- Are names meaningful?
- Is complexity manageable?
Review Process
- Understand the context and goal
- Read the code thoroughly
- Run the code if possible
- Leave specific, actionable comments
- Distinguish between blocking issues and suggestions
- Acknowledge good code, not just problems
Comment Types
- Blocking - Must be fixed before merge
- Suggestion - Nice to have, not required
- Question - Need clarification
- Nitpick - Style preference (prefix with "nit:")
Converted and distributed by TomeVault — claim your Tome and manage your conversions.