Code Review

Code Review

Use this skill to review correctness, maintainability, and dependency/test risks for a change set.

Scope

• Validate behavior against stated intent.
• Flag regressions, fragile logic, and missing tests.
• Run dependency/license checks when relevant.

Role-Specific Guardrails

• For userscript selector fallback arrays, require semantic validation before accepting a selector result.
• For observer + timeout helpers, verify timer cleanup on early resolve and teardown.
• For tests changed in scope, run npm run test:anti-patterns and report manual-only anti-pattern findings.

Output

• Findings by severity
• Suggested fixes
• Verification and anti-pattern results

Canonical References

• Workflow gates: docs/workflow/gates.md
• Handoff contract: docs/workflow/handoff-format.md

Mandatory Test Anti-Pattern Check (backend worker tests)

• Use docs/workflow/gates.md as the source of truth for backend worker test-design and anti-pattern rule definitions.
• Evaluate apps/backend/src/__tests__/workers/** against the canonical rule IDs and phase behavior from docs/workflow/gates.md.
• If any fail-level rule is present, return REQUEST CHANGES.
• Include evidence as rule ID + file:line for each finding.

Output Format

• Summary
• Critical Issues
• Suggestions
• Testing
• Test Anti-Pattern Check

References

• Review guidelines and checklist

Converted and distributed by TomeVault — claim your Tome and manage your conversions.