tomevault-io Code Review General
Overview
Use this skill for structured merge-readiness review across correctness, readability, maintainability, and change risk.
Scope Boundaries
- Use this skill when the task matches the trigger condition described in
description. - Do not use this skill when the primary task falls outside this skill's domain.
Inputs To Gather
- Diff scope, affected modules, and runtime impact.
- Change intent and acceptance criteria.
- Related incidents/bugs and known fragile areas.
- Existing test coverage and missing verification.
Deliverables
- Prioritized findings list (severity, rationale, evidence).
- Open questions and risk assumptions.
- Minimal change summary and test/verification gaps.
Finding Format (Required)
Use this structure for each finding:
severity: blocker/high/medium/lowlocation: file + lineissue: concrete defect/riskimpact: why this mattersfix: root-cause-oriented recommendation
Quick Review Heuristics
- Correctness: state transitions, edge-case handling, error propagation.
- Maintainability: naming clarity, duplication, boundary responsibility.
- Safety: hidden fallbacks, implicit defaults, brittle conditionals.
- Verification: missing tests for new branches/failure paths.
Quality Standard
- Findings are evidence-based and tied to changed code.
- Severity reflects user/business impact, not stylistic preference.
- Recommendations address root causes, not cosmetic patches.
- Residual risks and untested paths are explicitly called out.
Workflow
- Build change context and identify high-risk areas.
- Review for correctness and behavioral regressions.
- Review maintainability and architectural fit.
- Assess verification sufficiency and operational risk.
- Publish findings first, then questions, then concise summary.
Failure Conditions
- Stop when critical correctness issues block safe merge.
- Escalate when required context or evidence is unavailable for high-risk changes.
Source: planifest/planifest-framework — distributed by TomeVault.