tomevault-io Code Reviewer
Systematic approach to reviewing code changes with consistent, actionable feedback.
Review Process
- Understand context — Read PR description, linked issues, related files
- Identify scope — What changed? What's the intent? What could break?
- Review by area — Apply relevant checklists from references/checklists.md
- Check architecture — Does it follow project patterns? See references/dotnet-patterns.md for .NET/Clean Architecture
- Provide feedback — Use comment format below, prioritize blocking issues first
Comment Format
Use prefixes to indicate priority:
| Prefix | Meaning | Action |
|---|---|---|
[BLOCKING] |
Must fix before merge | Required |
[SUGGESTION] |
Improvement opportunity | Optional |
[QUESTION] |
Need clarification | Response needed |
[NIT] |
Minor style issue | Optional |
Structure each comment as:
[PREFIX] Brief issue description
Why: Explanation of the problem or risk
Fix: Suggested solution or alternative
Example:
[BLOCKING] SQL injection vulnerability in user search
Why: User input concatenated directly into query string
Fix: Use parameterized query
// Before
var sql = $"SELECT * FROM Users WHERE Name = '{input}'";
// After
var sql = "SELECT * FROM Users WHERE Name = @name";
cmd.Parameters.AddWithValue("@name", input);
Review Priority Order
Review in this order to catch critical issues first:
- Security — Auth, injection, data exposure, multi-tenant isolation
- Correctness — Logic errors, edge cases, data integrity
- Performance — N+1 queries, missing indexes, resource leaks
- Architecture — SOLID violations, wrong layer, circular dependencies
- Code quality — Naming, duplication, readability
- Testing — Missing tests, flaky patterns
- Documentation — Missing or outdated docs
Feedback Principles
- Point to exact lines with specific alternatives
- Explain why something is problematic, not just what
- Focus on code, not the author
- Acknowledge good patterns when found
- Batch related issues into a single comment
- For large PRs: focus on architecture and security first, nits later
References
- Review checklists: See references/checklists.md
- .NET/Clean Architecture patterns: See references/dotnet-patterns.md
- Angular patterns: See references/angular-patterns.md
- Flutter / Dart: See references/flutter-dart-patterns.md
Converted and distributed by TomeVault — claim your Tome and manage your conversions.