tomevault-io Review Skill
Perform code review focusing on quality, correctness, and maintainability.
Review Checklist
Correctness
- Logic errors or edge cases
- Error handling coverage
- Type safety and null checks
Code Quality (SOLID + Clean Code)
- Single Responsibility: One reason to change per class/function
- Open/Closed: Open for extension, closed for modification
- Liskov Substitution: Subtypes substitutable for base types
- Interface Segregation: Specific interfaces over general ones
- Dependency Inversion: Depend on abstractions
- DRY, YAGNI, meaningful names, Boy Scout Rule
- Functions: Small (<20 lines), do one thing, few args (0-2)
- No side effects, appropriate abstraction level
Style Compliance
- Type hints on all functions/methods
- Google-style docstrings
- Absolute imports only
- Line length under 120 chars
Testing
- Tests cover new functionality
- Tests verify behavior, not implementation
- Edge cases tested
- No flaky tests
Security
- No hardcoded secrets
- Input validation at boundaries
- Safe handling of user data
Process
- Read the code to understand its purpose
- Run through the review checklist
- Identify issues by category:
- Critical: Bugs, security issues
- Major: Design problems, missing tests
- Minor: Style, naming, documentation
- Provide actionable feedback with specific suggestions
- Note positive aspects of the code
Output Format
## Code Review
### Summary
Brief overview of the code's purpose and quality.
### Critical Issues
- Issue description and location
- Suggested fix
### Suggestions
- Improvement opportunities
- Alternative approaches
### Positive Notes
- Well-done aspects
Converted and distributed by TomeVault — claim your Tome and manage your conversions.