tomevault-io Review Standards
This skill contains the review taxonomy, team standards, and implementation checklists used by the Unit Work review system.
Contents
- Issue Patterns - 47 distinct patterns with detection criteria and fixes
- Review Standards - Language-agnostic best practices
- Checklists - Before, during, and after implementation
Severity Tiers
Issues are categorized into two tiers:
Tier 1 - Correctness (Always Higher Priority)
- Security vulnerabilities
- Architecture problems
- Implementation bugs
- Type safety violations
- Functionality gaps
Tier 2 - Cleanliness (Lower Priority)
- Naming clarity
- File organization
- Code duplication (when not causing bugs)
- Comment quality
- Import/style consistency
At the same P-level, Tier 1 issues should be addressed before Tier 2 issues.
Top 5 Patterns by Frequency
- BETTER_IMPLEMENTATION_APPROACH (18%) - Search first, leverage framework features
- TYPE_SAFETY_IMPROVEMENT (12%) - No casting, complete type guards
- EXISTING_UTILITY_AVAILABLE (10%) - Search codebase before implementing
- CODE_DUPLICATION (8%) - Check for existing implementations
- NULL_HANDLING (6%) - Use null, not empty strings
Always P1 (Critical)
- Any injection vulnerability
- Authentication/authorization bypass
- XSS in user content
- Security boundary violations
Zero-Tolerance Items
These should never appear in PRs:
- Type casting to access properties (
as SomeType) - Barrel files (index.ts re-exports)
- Debug code (console.log, print)
- Services that swallow errors
- Empty strings as null fallbacks
Usage
When conducting code review, reference the detailed patterns in issue-patterns.md for detection criteria and fix guidance.
Before implementing features, run through the checklists in checklists.md.
Converted and distributed by TomeVault — claim your Tome and manage your conversions.