Rust Review
Rule
Provide actionable, evidence-backed findings prioritized by correctness, safety, public
contracts, and maintainability. Do not rewrite code unless explicitly asked.
Review Focus
Check ownership design, lifetime complexity, public API ergonomics, error types, panic paths,
unsafe/FFI justification, feature flags, dependency choices, async cancellation, task
lifecycle, tests, docs, security boundaries, observability fields, and performance risks.
Antipatterns To Flag
unwrap/expect on user input, I/O, network, database, or request path failures.- Public APIs overfit to internal lifetimes or expose implementation details.
- Traits with a single implementation and no clear boundary value.
- Default features that surprise library users.
- Tokio runtime creation inside libraries.
Arc<Mutex<_>> used as a design shortcut.- Unsafe blocks without local safety comments and tests/Miri evidence where practical.
Workflow
- Inspect the diff,
Cargo.toml, features, tests, and nearby code.
- Run or recommend focused checks:
cargo test, cargo clippy, cargo fmt --check,
cargo deny check, cargo audit, or cargo nextest when configured.
- Identify blocking issues before optional style suggestions.
- Tie findings to concrete code and explain impact.
- Suggest small idiomatic fixes.
Completion
Return findings by severity, validation performed or skipped, and areas not reviewed.
Source: nyquistwilder/personal-pi — distributed by TomeVault.
1---2name: rust-review-43description: Review Rust changes for correctness, ownership, API ergonomics, error handling, unsafe boundaries, async behavior, tests, performance, features, dependency choices, and greenfield conventions. Use for review-only Rust tasks. Use when this capability is needed.4---56# Rust Review78## Rule910Provide actionable, evidence-backed findings prioritized by correctness, safety, public11contracts, and maintainability. Do not rewrite code unless explicitly asked.1213## Review Focus1415Check ownership design, lifetime complexity, public API ergonomics, error types, panic paths,16`unsafe`/FFI justification, feature flags, dependency choices, async cancellation, task17lifecycle, tests, docs, security boundaries, observability fields, and performance risks.1819## Antipatterns To Flag2021- `unwrap`/`expect` on user input, I/O, network, database, or request path failures.22- Public APIs overfit to internal lifetimes or expose implementation details.23- Traits with a single implementation and no clear boundary value.24- Default features that surprise library users.25- Tokio runtime creation inside libraries.26- `Arc<Mutex<_>>` used as a design shortcut.27- Unsafe blocks without local safety comments and tests/Miri evidence where practical.2829## Workflow30311. Inspect the diff, `Cargo.toml`, features, tests, and nearby code.322. Run or recommend focused checks: `cargo test`, `cargo clippy`, `cargo fmt --check`,33 `cargo deny check`, `cargo audit`, or `cargo nextest` when configured.343. Identify blocking issues before optional style suggestions.354. Tie findings to concrete code and explain impact.365. Suggest small idiomatic fixes.3738## Completion3940Return findings by severity, validation performed or skipped, and areas not reviewed.4142---43> Source: [nyquistwilder/personal-pi](https://github.com/nyquistwilder/personal-pi) — distributed by [TomeVault](https://tomevault.io).44<!-- tomevault:4.0:skill_md:2026-06-16 -->
tomevault-io