Verify Pr

Verify PR

Three-phase verification of the current branch's PR. Produces a structured report the developer reviews before deciding what to address.

Critical Rules

1. No changes = no verification. If git diff is empty, inform the user and stop.
2. Read before flagging. For every finding, read the surrounding file context. Never flag based on diff hunks alone.
3. Report, don't fix. Present the full verification report. Never apply changes without explicit developer approval.
4. Respect project conventions. Before Phase 2, look for TESTING.md, .agents/, or similar convention files in the repo root and follow them.

Workflow

Step 0: Gather Context

BRANCH=$(git rev-parse --abbrev-ref HEAD)
BASE=${USER_PROVIDED_BASE:-main}

git log $BASE...HEAD --oneline
git diff $BASE...HEAD --stat
git diff $BASE...HEAD

If no diff exists, inform the user and stop.

Also fetch the PR description if one exists:

gh pr view --json title,body,labels -q '.title, .body' 2>/dev/null

Use the PR title/description to understand the stated intent of the changes. If gh is not available, skip the PR description and proceed with the diff alone.

Phase 1: Code Review

Delegate to miguel-review. Run the miguel-review skill against the branch diff. It covers: dead code, scope creep, overengineering, naming, minimal diffs, and the deletion test.

If miguel-review is not available, perform a lightweight review covering the same areas: dead code, unjustified changes, scope creep, naming, complexity.

Then layer on these additional checks that miguel-review does not cover:

• Hallucination / fabrication: references to functions, modules, APIs, or types that don't exist in the codebase. Hardcoded values that look invented (URLs, addresses, constants). Copy-pasted code from unrelated contexts. For each suspect reference, search the codebase to confirm it exists.
• Correctness: logic errors, off-by-one, wrong operator, inverted conditions, incorrect return types.
• Data integrity: mutations without validation, missing null/undefined checks on external data, type coercions that lose information, unhandled promise rejections.

Record all Phase 1 findings (both from miguel-review and the addendum) for the final report.

Phase 2: Test Verification

Read project testing conventions first. Look for TESTING.md, docs/TESTING.md, or similar files in the repo root.

Phase 2a: Test Plan

For each meaningful change in the diff, produce a test plan entry:

To classify coverage, don't just check if a .test.* or .spec.* file exists -- look inside it:

• Direct: the test file references the changed function, class, or endpoint by name.
• Indirect: the test file imports the changed module but does not exercise the specific change.
• None: no test file references the changed code.

For each changed file, search for co-located test files (.test.*, .spec.*) and grep inside them and in integration/e2e test directories for references to changed symbols.

Phase 2b: Test Execution

After building the test plan, run the relevant tests. Do not ask -- running tests is read-only observation, not a fix.

Detect the test runner. Check in order of specificity. Also inspect package.json scripts.test, Makefile, or justfile for test targets.

If no runner is detected, report "No test runner detected. Test verification skipped." and skip to Phase 3.

Run relevant tests. Prefer targeted runs over the full suite:

• Run only the test files identified in Phase 2a that have Direct or Indirect coverage.
• Example: npx vitest run src/auth/login.test.ts src/auth/session.test.ts
• Fall back to the full suite if no specific test files were identified but a runner exists.
• Set a timeout of 5 minutes. If tests exceed this, kill the process and report a timeout.

Capture and report results.

• Pass / fail / skip counts
• Failing test names with error messages (truncate verbose output to key lines)
• Exit code
• Duration

Phase 3: Upstream Assumption Verification

Scan the diff for assumptions that depend on external sources of truth. Common categories:

• Imported types or functions from other packages -- verify they exist and match the expected signature.
• DB schema expectations -- verify column names, types, and constraints match the schema definition.
• API contracts -- verify endpoint paths, request/response shapes match the API spec or route definitions.
• Environment variables -- verify they exist in .env.example and compose files.
• Config values -- verify defaults and expected shapes match the config source.
• Hardcoded URLs, addresses, selectors -- verify they resolve or match the intended target.

For each assumption found:

1. Identify what is assumed (1 sentence).
2. Trace to the source of truth (specific file + line).
3. Verify it holds: Confirmed or Unverified (with reason).

Output Template

Present the full report using this structure:

## PR Verification: `{branch}` -> `{base}`

**PR**: {title}
**Files changed**: {count} | **Additions**: +{n} | **Deletions**: -{n}

---

### Phase 1: Code Review

{miguel-review output}

#### Additional Checks

| # | File | Line | Finding | Severity |
|---|------|------|---------|----------|
| 1 | path/to/file.ts | 42 | Description of issue | Critical / Warning / Nit |

If none: "No additional issues beyond the code review above."

---

### Phase 2: Test Verification

#### 2a. Test Plan

| # | Change | What to test | Expected result | Type | Location | Coverage |
|---|--------|-------------|-----------------|------|----------|----------|
| 1 | ... | ... | ... | Unit | ... | Direct |
| 2 | ... | ... | ... | Unit | ... | None |

**Gaps**: {count} changes without existing test coverage.

#### 2b. Test Results

**Runner**: {runner} | **Command**: `{command}`

| Status | Count |
|--------|-------|
| Passed | {n} |
| Failed | {n} |
| Skipped | {n} |

**Failures:**
- `path/to/test.ts > test name` -- error message

**Duration**: {n}s

---

### Phase 3: Upstream Assumptions

| # | Assumption | Source of truth | Status |
|---|-----------|----------------|--------|
| 1 | `UserSchema` has `email` field | `src/db/schema.ts:45` | Confirmed |
| 2 | `POST /api/users` accepts `role` | Not found | Unverified |

---

### Verdict

One sentence: what's the overall state of this PR?

### Recommended Actions
Numbered list of concrete next steps, ordered by priority.

Anti-Patterns

• Do NOT duplicate the miguel-review checks -- delegate, don't reimplement.
• Do NOT suggest tests for trivial changes (import reordering, type-only changes, formatting).
• Do NOT fabricate source-of-truth paths -- if you can't find the upstream source, say "Unverified."
• Do NOT apply fixes without developer approval. Running tests is observation, not a fix -- always run them.
• Do NOT skip Phase 2b or Phase 3. Run targeted tests when specific files are available; fall back to the full suite.
• Do NOT treat flaky tests (pass on retry) as failures -- note them as flaky in the report.