309 Rerender Simple Expression In Memo 5bdcf2d1

Do not wrap a simple expression with a primitive result type in useMemo

tools-only Updated 7 repo stars

File contents

Do not wrap a simple expression with a primitive result type in useMemo

When an expression is simple (few logical or arithmetical operators) and has a primitive result type (boolean, number, string), do not wrap it in useMemo. Calling useMemo and comparing hook dependencies may consume more resources than the expression itself.

Incorrect:

function Header({ user, notifications }: Props) {
  const isLoading = useMemo(() => {
    return user.isLoading || notifications.isLoading
  }, [user.isLoading, notifications.isLoading])

  if (isLoading) return <Skeleton />
  // return some markup
}

Correct:

function Header({ user, notifications }: Props) {
  const isLoading = user.isLoading || notifications.isLoading

  if (isLoading) return <Skeleton />
  // return some markup
}

tools-only/X-Skills/tree/main/automation/scripting/309-rerender-simple-expression-in-memo_5bdcf2d1 commit 59dfab0f3b

Frequently asked questions

npx skillmds@latest add tools-only/309-rerender-simple-expression-in-memo-5bdcf2d1