File contents Review Checklist
Comprehensive Review Checklist
Category
Key Questions
Design Does it fit existing patterns? Right abstraction level?
Logic Edge cases handled? Race conditions? Null checks?
Security Input validated? Auth checked? Secrets safe?
Performance N+1 queries? Memory leaks? Caching needed?
Tests Adequate coverage? Edge cases tested? Mocks appropriate?
Naming Clear, consistent, intention-revealing?
Error Handling Errors caught? Meaningful messages? Logged?
Documentation Public APIs documented? Complex logic explained?
Review Process
1. Context (5 min)
2. Structure (10 min)
3. Code Details (20 min)
4. Tests (10 min)
5. Final Pass (5 min)
Category Deep Dive
Design Questions
Does this change belong in this file/module?
Is the abstraction level appropriate?
Could this be simpler?
Does it follow existing patterns?
Is it extensible without modification?
Logic Questions
What happens with null/undefined inputs?
Are boundary conditions handled?
Could there be race conditions?
Is the order of operations correct?
Are all code paths tested?
Security Questions
Is all user input validated?
Are SQL queries parameterized?
Is output properly encoded?
Are secrets handled safely?
Is authentication checked?
Is authorization enforced?
Performance Questions
Are there N+1 query patterns?
Is data fetched efficiently?
Are expensive operations cached?
Could this cause memory leaks?
Is pagination implemented?
Quick Reference
Review Focus
Time %
Context & PR description
10%
Architecture & design
20%
Code logic & details
40%
Tests & coverage
20%
Final review & summary
10%
1 --- 2 name: 921-review-checklist-c0e348f3 3 description: Review Checklist 4 --- 5 # Review Checklist 6 7 ## Comprehensive Review Checklist 8 9 | Category | Key Questions | 10 |----------|---------------| 11 | **Design** | Does it fit existing patterns? Right abstraction level? | 12 | **Logic** | Edge cases handled? Race conditions? Null checks? | 13 | **Security** | Input validated? Auth checked? Secrets safe? | 14 | **Performance** | N+1 queries? Memory leaks? Caching needed? | 15 | **Tests** | Adequate coverage? Edge cases tested? Mocks appropriate? | 16 | **Naming** | Clear, consistent, intention-revealing? | 17 | **Error Handling** | Errors caught? Meaningful messages? Logged? | 18 | **Documentation** | Public APIs documented? Complex logic explained? | 19 20 ## Review Process 21 22 ### 1. Context (5 min) 23 - [ ] Read PR description 24 - [ ] Understand the problem being solved 25 - [ ] Check linked issues/tickets 26 - [ ] Note expected changes 27 28 ### 2. Structure (10 min) 29 - [ ] Review file organization 30 - [ ] Check architectural fit 31 - [ ] Verify design patterns used 32 - [ ] Note any breaking changes 33 34 ### 3. Code Details (20 min) 35 - [ ] Review logic correctness 36 - [ ] Check edge cases 37 - [ ] Verify error handling 38 - [ ] Look for security issues 39 - [ ] Check performance concerns 40 - [ ] Review naming clarity 41 42 ### 4. Tests (10 min) 43 - [ ] Verify test coverage 44 - [ ] Check test quality 45 - [ ] Look for edge case tests 46 - [ ] Ensure mocks are appropriate 47 48 ### 5. Final Pass (5 min) 49 - [ ] Note positive patterns 50 - [ ] Prioritize feedback 51 - [ ] Write summary 52 53 ## Category Deep Dive 54 55 ### Design Questions 56 - Does this change belong in this file/module? 57 - Is the abstraction level appropriate? 58 - Could this be simpler? 59 - Does it follow existing patterns? 60 - Is it extensible without modification? 61 62 ### Logic Questions 63 - What happens with null/undefined inputs? 64 - Are boundary conditions handled? 65 - Could there be race conditions? 66 - Is the order of operations correct? 67 - Are all code paths tested? 68 69 ### Security Questions 70 - Is all user input validated? 71 - Are SQL queries parameterized? 72 - Is output properly encoded? 73 - Are secrets handled safely? 74 - Is authentication checked? 75 - Is authorization enforced? 76 77 ### Performance Questions 78 - Are there N+1 query patterns? 79 - Is data fetched efficiently? 80 - Are expensive operations cached? 81 - Could this cause memory leaks? 82 - Is pagination implemented? 83 84 ## Quick Reference 85 86 | Review Focus | Time % | 87 |--------------|--------| 88 | Context & PR description | 10% | 89 | Architecture & design | 20% | 90 | Code logic & details | 40% | 91 | Tests & coverage | 20% | 92 | Final review & summary | 10% |
commit 1ec2bde205
Frequently asked questions How do I install the 921 Review Checklist C0e348f3 skill? Run npx skillmds@latest add tools-only/921-review-checklist-c0e348f3 in your terminal (requires Node.js), paste this page's agent-chat prompt into Claude, Cursor, or any MCP-connected agent, or download the SKILL.md file and copy it into your agent's skills directory.
What does the 921 Review Checklist C0e348f3 skill do? Review Checklist It is listed under Security on SkillMD.
Is 921 Review Checklist C0e348f3 safe to use? This skill has not completed SkillMD's automated safety review yet. SkillMD never runs a skill's scripts for you; review the SKILL.md before installing.
Which AI agents work with 921 Review Checklist C0e348f3? This skill is tagged as working with Claude Code, Claude.ai, OpenAI Codex. SKILL.md is an open format, so most agents that read a skills directory can load it too.
Is 921 Review Checklist C0e348f3 free to use? Yes. Installing skills from SkillMD is free, and the skill stays under its author's original license.
Who published 921 Review Checklist C0e348f3? tools-only (@tools-only) published this skill. Their other Agent Skills are listed on their SkillMD profile.
tools-only