App Intents Code Review

Reviews App Intents code for intent structure, entities, shortcuts, and parameters. Use when reviewing code with import AppIntents, @AppIntent, AppEntity, AppShortcutsProvider, or @Parameter.

tools-only cfaac03 3 files · 5.4 KB Updated Sep 8, 2026 7 repo stars

Coding & Dev Tools

Install

Press C to copy

$ npx skillmds add tools-only/app-intents-code-review

Installs into ~/.claude/skills (or .claude/skills inside a project). Restart Claude Code to pick it up.

＋ Add to collection

README badge

[![SkillMD](https://skillmd.com/badge/tools-only/app-intents-code-review.svg)](https://skillmd.com/skills/tools-only/app-intents-code-review)

Trust & safety

Audits pending

Not yet audited · commit cfaac03

Permissions this skill uses

Documentation only
No scripts, network access, or credentials are involved.

Works with: Claude Code Claude.ai OpenAI Codex +

File contents

App Intents Code Review

Quick Reference

Issue Type	Reference
AppIntent protocol, perform(), return types	references/intent-structure.md
AppEntity, EntityQuery, identifiers	references/entities.md
AppShortcutsProvider, phrases, discovery	references/shortcuts.md
@Parameter, validation, dynamic options	references/parameters.md

Review Checklist

perform() marked with @MainActor if accessing UI/main thread resources
perform() completes within 30-second timeout (no heavy downloads/processing)
Custom errors conform to CustomLocalizedStringResourceConvertible
EntityQuery.entities(for:) handles missing identifiers gracefully
EntityStringQuery used if Siri voice input needed (not plain EntityQuery)
suggestedEntities() returns reasonable defaults for disambiguation
AppShortcut phrases include .applicationName parameter
Non-optional @Parameter has sensible defaults or uses requestValue()
@IntentParameterDependency not used on iOS 16 targets (crashes)
Phrases localized in AppShortcuts.strings, not Localizable.strings
App Intents defined in app bundle, not Swift Package (pre-iOS 17)
isDiscoverable = false for internal/widget-only intents

When to Load References

AppIntent protocol implementation -> intent-structure.md
Entity queries, identifiers, Spotlight -> entities.md
App Shortcuts, phrases, discovery -> shortcuts.md
Parameter validation, dynamic options -> parameters.md

Review Questions

Does perform() handle timeout limits for long-running operations?
Are entity queries self-contained (no @Dependency injection in Siri context)?
Do phrases read naturally and include the app name?
Are SwiftData models passed by persistentModelID, not directly?
Would migrating from SiriKit break existing user shortcuts?

---name: app-intents-code-reviewdescription: Reviews App Intents code for intent structure, entities, shortcuts, and parameters. Use when reviewing code with import AppIntents, @AppIntent, AppEntity, AppShortcutsProvider, or @Parameter.---# App Intents Code Review## Quick Reference| Issue Type | Reference ||------------|-----------|| AppIntent protocol, perform(), return types | [references/intent-structure.md](references/intent-structure.md) || AppEntity, EntityQuery, identifiers | [references/entities.md](references/entities.md) || AppShortcutsProvider, phrases, discovery | [references/shortcuts.md](references/shortcuts.md) || @Parameter, validation, dynamic options | [references/parameters.md](references/parameters.md) |## Review Checklist- [ ] `perform()` marked with `@MainActor` if accessing UI/main thread resources- [ ] `perform()` completes within 30-second timeout (no heavy downloads/processing)- [ ] Custom errors conform to `CustomLocalizedStringResourceConvertible`- [ ] `EntityQuery.entities(for:)` handles missing identifiers gracefully- [ ] `EntityStringQuery` used if Siri voice input needed (not plain `EntityQuery`)- [ ] `suggestedEntities()` returns reasonable defaults for disambiguation- [ ] `AppShortcut` phrases include `.applicationName` parameter- [ ] Non-optional `@Parameter` has sensible defaults or uses `requestValue()`- [ ] `@IntentParameterDependency` not used on iOS 16 targets (crashes)- [ ] Phrases localized in `AppShortcuts.strings`, not `Localizable.strings`- [ ] App Intents defined in app bundle, not Swift Package (pre-iOS 17)- [ ] `isDiscoverable = false` for internal/widget-only intents## When to Load References- AppIntent protocol implementation -> intent-structure.md- Entity queries, identifiers, Spotlight -> entities.md- App Shortcuts, phrases, discovery -> shortcuts.md- Parameter validation, dynamic options -> parameters.md## Review Questions1. Does `perform()` handle timeout limits for long-running operations?2. Are entity queries self-contained (no `@Dependency` injection in Siri context)?3. Do phrases read naturally and include the app name?4. Are SwiftData models passed by `persistentModelID`, not directly?5. Would migrating from SiriKit break existing user shortcuts?

tools-only/X-Skills/tree/main/development/003-name-skill_2aa02bf2 commit cfaac03ec6

Frequently asked questions

npx skillmds add tools-only/app-intents-code-review