Groomed (2026-02-24)
Reproducibility
Original problem (pre-fix):
- Open
plugins/gitlab-skill/skills/gitlab-skill/scripts/validate_glfm.pylines 152–153 — default--gitlab-urlwashttps://sourcery.assaabloy.net - Open
plugins/gitlab-skill/skills/gitlab-skill/references/gitlab-ci-local-guide.mdline 51 — example URL referenced same corporate host
Verification (post-fix):
rg "sourcery\.assaabloy\.net" plugins/gitlab-skillreturns no matches- Both locations use
https://gitlab.example.com
Output / Evidence
- Commit: 103cbf6c2d1e865bdd6afdef6e3d5912ff7bab2b —
fix(gitlab-skill): replace hardcoded corporate URL with generic placeholder - Files changed:
validate_glfm.py(default arg + help text),gitlab-ci-local-guide.md(example URL),plugin.json,marketplace.json,BACKLOG.md - Fact-check: All three claims verified (validate_glfm.py, gitlab-ci-local-guide.md, fix applied)
Priority
8/10 — Corporate URL in a public repo is a security/privacy leak; affects all contributors and downstream users.
Impact
- Before: Internal corporate host exposed in public code
- After: Generic placeholder; no internal infrastructure exposed
Benefits
- Public repo no longer exposes internal URLs
- Script and docs use generic placeholder suitable for any GitLab instance
--gitlab-urlremains optional with a safe default
Expected Behavior
validate_glfm.py --gitlab-urldefaults tohttps://gitlab.example.com(or equivalent generic placeholder)- Documentation examples use generic URLs, not internal hosts
Desired Structure
- Default URL: generic placeholder (e.g.,
https://gitlab.example.com) - Alternative: make
--gitlab-urlrequired with no default - Chosen approach: generic placeholder (keeps backward compatibility)
Acceptance Criteria
-
validate_glfm.pylines 152–153 usehttps://gitlab.example.comas default -
gitlab-ci-local-guide.mdline 51 useshttps://gitlab.example.comin examples - No references to
sourcery.assaabloy.netremain in the repo
Resources
| Type | Item |
|---|---|
| Skill | gitlab-skill (plugins/gitlab-skill/skills/gitlab-skill/) |
| Skill | glab-cli-ci-debugging (Cursor skill for GitLab CI debugging) |
| Agent | @plugin-assessor (gitlab-skill audit) |
| Prior work | completed-replace-requests-with-httpx-in-all-scripts — validate_glfm.py migrated to httpx |
| Prior work | ideas-gitlab-skill-gitlab-ci-glfm-validation-mcp — MCP wrapper for validate_glfm |
| Commit | 103cbf6 |
Effort
Small — two locations updated in a single commit.