/iproute-review - iproute2 Patch Review
Using the prompt review-core.md and the review prompt directory, do a deep
dive regression analysis of the top commit, or the provided patch/commit.
Instructions
- Load
review-core.mdfor the core checklist - Identify what subsystems the patch touches (ip, tc, bridge, lib, etc.)
- Load relevant context files:
json-output.mdfor JSON output changesargument-parsing.mdfor CLI parsing changeskernel-compat.mdfor new kernel feature supportcoding-style.mdfor style questions
- Review against the checklist
- If issues found, create review output in email format
Key Areas for iproute2
- matches() vs strcmp(): New code must use strcmp(), not matches()
- JSON output: All display output must use print_XXX() helpers
- Error handling: stderr for errors, proper cleanup on failures
- Netlink: Proper attribute handling and error checking
Output
If regressions are found, create review-inline.txt with email-style feedback
suitable for the netdev mailing list.