TrevorS Implementing Issues
Work through an issue with TDD, proper branch management, and PR creation.
Workflow
- Auto-detect VCS --
jj rootsucceeds -> jj, otherwise git - Auto-detect issue tracking -- numeric/#number -> GitHub (gh), TEAM-ID format -> Linear (linear-cli)
- Check working copy status -- ensure not on main/master/dev
- Create feature branch with proper naming
- Read and understand issue requirements
- Review project context -- spec.md, requirements.md, CLAUDE.md
- Follow TDD -- write tests first
- Implement minimal code to pass tests
- Refactor incrementally while maintaining coverage
- Clean up history -- squash/curate commits
- Push with upstream tracking and create PR
- Write complete PR description with test plan
Branch Naming
- GitHub:
feature/issue-{number}-{short-description}orfix/issue-{number}-{description} - Linear:
feature/{team-id}-{short-description}orfix/{team-id}-{description}
Branch Safety
jj:
jj log -r @ --no-graph -T 'bookmarks'
# If on main, create new change:
jj new main -m "feat: description"
jj git fetch
git:
git branch --show-current
# If on protected branch, create feature branch:
git checkout -b "feature/issue-<number>-<description>"
git fetch origin
Implementation Standards
- Write failing tests first capturing acceptance criteria
- Implement minimal code to make tests pass
- Refactor while maintaining green tests
- Follow project patterns from CLAUDE.md
- Add meaningful comments for complex logic
- Update docs if public APIs change
Push and PR
jj:
jj squash -m "feat: final commit message"
jj bookmark set <branch> -r @
jj git push --bookmark <branch>
git:
git push -u origin HEAD
PR creation:
Write the body with the Write tool, then pass it by path — no heredocs:
gh pr create --title "[Issue #<number>] Title" --body-file <scratchpad>/pr-body.md
Body template:
## Summary
<bullets>
## Test plan
- [ ] Tests pass
- [ ] Manual verification
In a jj-colocated repo git HEAD is detached, so also pass --head <bookmark> —
gh cannot infer the branch. See the using-jj skill.
Command Reference
# GitHub
gh issue view <number> --json title,body,labels,assignees,milestone
gh pr create --title "title" --body "body"
# Linear
linear-cli issues
linear-cli issue <team-id>