tw93 MiaoYan Code Review Adapter
Use Waza /check for the generic review method. This adapter adds MiaoYan-specific commands, hard stops, and target awareness.
Quick Commands
# View PR diff
gh pr diff 123
# Build check
xcodebuild -project MiaoYan.xcodeproj -scheme MiaoYan -configuration Debug build
# Lint
swiftlint lint --strict
# Format check
swift-format lint --recursive . --strict
MiaoYan-Specific Checks
- No retain cycles (weak/unowned used correctly)
- Main thread UI updates only
- File I/O uses proper error handling
- No force unwraps (
!) without justification - Follows existing patterns in the codebase
- No unnecessary class where struct suffices
- Uses Swift concurrency correctly (async/await, actors)
- Keep the macOS editor core, preview pipeline, and existing storyboard scenes on AppKit; new self-contained panels may host SwiftUI through
NSHostingView.MiaoYanMobile/uses SwiftUI, without sharing UI layers across targets - SwiftLint passes:
swiftlint lint --strict - No dead code or commented-out blocks
- Clear naming, no abbreviations
- No new external network calls without user consent
- File writes are scoped to user documents or app-controlled locations
- No shell injection in CLI-related code
- Changes under
MiaoYanMobile/consider target membership, sync behavior, and mobile resource paths
Review Output Format
Follow Waza /check: findings first, ordered by severity, with tight file/line references. Keep summaries brief.
Safety Rules
- NEVER post review comments without explicit user request.
- ALWAYS prepare feedback for user review first.
- Draft responses in the same language as the PR author.