MME Static Review
Overview
Review MME code as both HLSL and MME pipeline configuration. Findings should lead, with file and line references whenever possible.
Review Checklist
MME script:
STANDARDSGLOBALhas correctScriptClass,ScriptOrder, andScriptOutput.- Technique
Scriptroutes render targets and passes in the intended order. - Pass-level
ScriptcontainsDraw=BufferorDraw=Geometrywhere required. - Final screen draw restores empty color/depth targets when needed.
ScriptExternal=Colorappears before sampling scene color.- Loop counters and
LoopEndare paired.
Targets/resources:
- Render target names match samplers and script strings exactly.
- Formats are supported by intended hardware.
- Clear values make sense.
DefaultEffectroutes include required wildcards and hide controllers.- Include/resource paths are relative to the effect file.
Model shader:
- Required
object,object_ss,shadow,edge,zplottechniques exist or intentionally no-op. UseTexture,UseSphereMap,UseToon, andSubsetvariants cover target materials.- MMD samplers are not overwritten accidentally.
- Alpha and transparent materials are handled intentionally.
Framework:
- ray-mmd/sdPBR buffers and G-buffer layouts match the local version.
- ExcellentShadow adaptations include the required system sections and fallback path.
- Config
.fxsubchanges are documented as requiring MME refresh.
Output Format
Findings:
- [Severity] file:line - Issue and impact.
Open questions:
- ...
Review notes:
- ...
If no issues are found, say so clearly and list remaining runtime risks.
Useful Commands
rg -n "TODO|FIXME|STANDARDSGLOBAL|ScriptClass|ScriptOrder|string Script|Draw=|MMDPass|OFFSCREENRENDERTARGET|RENDERCOLORTARGET|CONTROLOBJECT" <file-or-dir>
rg -n "RenderColorTarget|RenderDepthStencilTarget|Pass=|LoopByCount|LoopEnd|ScriptExternal|Clear=" <file-or-dir>
References
../mmd-mme-workflow/references/mme-core-reference.md../mmd-mme-workflow/references/debug-checklist.md../mmd-mme-workflow/references/framework-notes.md