Split Test Files

Review that new feature tests are split into their own file rather than added to an already large test file.

kubernetes-sigs Updated

File contents

Skill: Split Large Test Files for New Features

Flag: A PR adds substantial test coverage for a new feature to an already large test file (e.g., scheduler_test.go, workload_controller_test.go).

When to split — all three conditions should hold:

  1. The feature has a distinct name that maps cleanly to a file suffix (e.g., _tas, _afs, _concurrentadmission).
  2. The new tests require feature-specific setup — enabling a feature gate, constructing feature-specific resources — that is unrelated to the base test suite's setup.
  3. The new tests would add a significant block of lines (roughly 150+) to a file that is already large.

Ask: Extract the feature's tests into <package>_<feature>_test.go. Precedent: scheduler_tas_test.go, scheduler_afs_test.go. This keeps the base file navigable and makes feature-specific scenarios easy to find and extend.

kubernetes-sigs/kueue/tree/main/cmd/experimental/skills/reviewer/split-test-files commit 294b8d9944

Frequently asked questions

npx skillmds@latest add kubernetes-sigs-kueue/split-test-files