kubernetes-sigs
- 60 skills
- 0 followers
- 3.2k repo stars
- last month last updated
- ▌ Duplicated Logic · kubernetes-sigs-kueueFlag identical (or near-identical) blocks across types/adapters/call sites that should live in a shared helper — and newly extracted helpers with only one caller.
- ▌ Missing Deferred Removal Markers · kubernetes-sigs-kueueFlag temporary or deprecated compatibility-shim code kept in the diff without a deferred-removal comment naming the removal version and a tracking issue.
- ▌ Annotation Label Namespace Abuse · kubernetes-sigs-kueueFlag generic loops over obj.Annotations that copy, forward, or echo values — allow tenant injection into reserved kueue.x-k8s.io/ namespace.
- ▌ Illogical Structure · kubernetes-sigs-kueueFlag code organization that a future maintainer will struggle to follow, modify, or extend.
- ▌ Unnecessary Guard Conditions · kubernetes-sigs-kueueFlag extra checks that are logically unreachable at the call site — they add noise and can mask future regressions.
- ▌ Integration Adapter Trust Boundary · kubernetes-sigs-kueueFlag integration adapters reading credential-like fields from third-party CRDs without treating them as untrusted (RayCluster, SparkApplication, JobSet).
- ▌ Avoidable Complexity · kubernetes-sigs-kueueFlag solutions more elaborate than the problem requires — complexity that exists only because the author reached for a pattern.
- ▌ Feature Gate Interaction Bugs · kubernetes-sigs-kueueFlag feature-gated behavior whose gate-off path is incorrect — early returns that skip cleanup, or state set only when on but read unconditionally.
- ▌ Nonsensical Decisions · kubernetes-sigs-kueueFlag unnecessary indirection, mismatched abstractions, or confusing data flow that obscures what the code is doing.
- ▌ Deleted Backwards Compatibility Code · kubernetes-sigs-kueueHard blocker — flag removal or relocation of code that manages cluster state owned by previous controller versions.
- ▌ Pointless Intermediate Variables · kubernetes-sigs-kueueFlag redundant local variables that add noise without adding clarity.
- ▌ Algorithm Comments · kubernetes-sigs-kueueReview that algorithm comments match the implementation. Use when a comment describes a formula or algorithm and you want to verify it matches what the code actually does.
- ▌ Feature Gated Code · kubernetes-sigs-kueueReview that new feature-gated behavior has explicit gate checks on all reachable code paths.
- ▌ Metrics Label Sets · kubernetes-sigs-kueueReview that new ClusterQueue metrics use the same label set as existing ClusterQueue metrics.
- ▌ Table Driven Tests · kubernetes-sigs-kueueReview that tests covering multiple scenarios use table-driven style instead of inline sequential blocks.
- ▌ Visibility Exports · kubernetes-sigs-kueueReview that newly exported functions have callers outside the package, lowercasing those that don't.
- ▌ Nil Safety · kubernetes-sigs-kueueFlag unguarded dereferences of optional pointer fields reachable from a malformed CR, and goroutines without recover (CWE-476).
- ▌ Metrics Feature Gates · kubernetes-sigs-kueueReview that new metrics are gated by the same feature flags as similar existing metrics.
- ▌ Terminology Semantics · kubernetes-sigs-kueueReview that code and events use terminology whose semantics match the operation (e.g., not Preempted for migration).
- ▌ Encapsulate Paired Ops · kubernetes-sigs-kueueReview that paired operations and fields that always appear together are encapsulated in a helper or nested struct.
- ▌ Push Guards To Callees · kubernetes-sigs-kueueReview that repeated guards at multiple call sites are moved inside the callee instead.
- ▌ Path Traversal · kubernetes-sigs-kueueFlag file paths built from user-supplied names without sanitization, symlink-following in tenant dirs, and unvalidated archive extraction (CWE-22).
- ▌ Over Commenting · kubernetes-sigs-kueueFlag comments that explain what self-documenting code already says.
- ▌ Input Validation · kubernetes-sigs-kueueFlag missing input validation at trust boundaries — user-settable CR fields, webhook payloads, labels, annotations, or untrusted deserialization (CWE-20, CWE-502).
- ▌ Logic Errors · kubernetes-sigs-kueueFlag incorrect conditionals, inverted boolean checks, off-by-one errors, unhandled edge cases, race conditions, or mishandled error returns.
- ▌ Code Style Typos · kubernetes-sigs-kueueFlag typos in identifiers, strings, or any text introduced by the diff.
- ▌ Convention Drift · kubernetes-sigs-kueueFlag new code that breaks naming conventions already established in the same file or package.
- ▌ Inaccurate Comments · kubernetes-sigs-kueueFlag any comment or docstring that no longer matches the code — these mislead future maintainers who trust them.
- ▌ Reinvented Helpers · kubernetes-sigs-kueueFlag logic that duplicates an existing util/helper function instead of reusing it.
- ▌ Integration Tests For Updates · kubernetes-sigs-kueueReview that update/mutation logic has integration test coverage in test/integration/.
- ▌ Supply Chain Hygiene · kubernetes-sigs-kueueFlag supply-chain hygiene gaps — unpinned image refs, TLS bypass, unjustified go.mod replace directives, curl|sh, moving-tag GitHub Actions (CWE-295, CWE-494).
- ▌ Wrong Log Verbosity · kubernetes-sigs-kueueFlag per-reconcile-cycle log lines emitted at V(2) — recurring reconcile-loop logs must be V(4) or higher.
- ▌ Wrong Kind Of Comment · kubernetes-sigs-kueueFlag comments that describe *what* the code does instead of *why* it does it.
- ▌ Misaligned Test Names · kubernetes-sigs-kueueFlag unit or integration test function names that do not reflect the function or behavior under test.
- ▌ Scope Creep · kubernetes-sigs-kueueFlag diffs that bundle a bugfix with an unrelated refactor, or generalize a change to all types when only one type needs it.
- ▌ Webhook Safety Regressions · kubernetes-sigs-kueueFlag webhook safety regressions — loosened failurePolicy, shortened timeoutSeconds, TLS bypass paths, non-idempotent mutating webhooks.
- ▌ Feature Gated Insecure Paths · kubernetes-sigs-kueueFlag feature-gated behavior whose security assumptions do not hold in both gate-on and gate-off states; require a comment near the gate check for new alpha attack surface.
- ▌ Misplaced Logic · kubernetes-sigs-kueueFlag code put somewhere a reader would not expect to find it — cleanup scattered across callers, validation deep in business logic.
- ▌ Resource Bounds Dos · kubernetes-sigs-kueueFlag missing resource bounds / DoS resistance — uncapped loops or allocations, missing timeouts, reconciler-wedging input, unbounded metric cardinality (CWE-400, CWE-770).
- ▌ Authn Authz Relaxation · kubernetes-sigs-kueueFlag AuthN/AuthZ relaxation — webhook token skipping, failurePolicy Ignore, missing SubjectAccessReview, wildcard RBAC, privileged pod specs (CWE-269, CWE-287, CWE-306, CWE-862, CWE-863).
- ▌ Information Disclosure · kubernetes-sigs-kueueFlag information-disclosure patterns — full-object logging, request echoing, credentials in status/annotations, kubeconfig logging, secret-bearing status (CWE-200, CWE-522, CWE-532, CWE-552).
- ▌ Was Cluster · kubernetes-sigs-kueueBuild and manage a kind cluster for Workload-Aware Scheduling (WAS) e2e tests. Use when the user wants to set up, run tests against, or tear down a WAS test cluster built from Kubernetes main.
- ▌ Kueue Lineage · kubernetes-sigs-kueueTrace workload lineage to pods. Use when a user wants to trace lineage across any tier such as workload to pods, pod to workload, or job to workload. The user may provide a resource at any level (Workload, Job, Pod, JobSet, etc.) and this skill produces the full tree from Workload down to Pods.
- ▌ Comments · kubernetes-sigs-kueueReview a diff for comment hygiene — over-commenting, what-not-why narration, inaccurate comments, and missing TODOs on compatibility shims.
- ▌ Security · kubernetes-sigs-kueueReview a diff for security issues exploitable by a tenant, neighbouring controller, or malicious workload spec — input validation, injection, DoS, nil-safety, authz, info disclosure, supply chain, webhook safety.
- ▌ Code Eval · kubernetes-sigs-kueueEvaluate the quality of a git diff between two commits by delegating per-skill analysis (Code Style, Buggy Behavior, Comments, Architectural Decisions, Security) to subagents, then aggregating their findings and recommendations into a scored report.
- ▌ Kueue Release Notes · kubernetes-sigs-kueueWrite or review Kueue PR release notes. Use when a user asks to draft, refine, validate, or combine release notes for a Kueue pull request, especially when deciding whether the note should be framed as a bugfix, feature, observability improvement, or breaking change.
- ▌ Kueue Who Preempted · kubernetes-sigs-kueueIdentify what preempted a workload. Use when a user asks why their workload was evicted or preempted, or wants to identify what preempted it. Investigates Kubernetes events, workload status conditions, and controller logs to trace preemption.
- ▌ Code Style · kubernetes-sigs-kueueReview a diff for naming precision, convention drift, reinvented helpers, log-verbosity mistakes, misaligned test names, and typos.
- ▌ Kueue Flake Debugger · kubernetes-sigs-kueueDebug Kueue CI flakes. Use when a user asks to debug a flake, investigate a test failure, a test timeout, or a CI flake. Analyzes Prow build logs, kube-scheduler logs, kubelet logs, and test code to identify root causes.
- ▌ Buggy Behavior · kubernetes-sigs-kueueReview a diff for behavioral defects — logic errors, broken edge cases, feature-gate bugs, and deletions that break backwards compatibility during rolling upgrades.
- ▌ Extract Helpers · kubernetes-sigs-kueueReview that local variables with unnecessarily wide scope are extracted into helper functions.
- ▌ Race Conditions · kubernetes-sigs-kueueReview concurrent Go code for races, preferring fixes at the mutation site over adding snapshot fields.
- ▌ Split Test Files · kubernetes-sigs-kueueReview that new feature tests are split into their own file rather than added to an already large test file.
- ▌ API Field Comments · kubernetes-sigs-kueueReview that new CRD fields have complete godoc comments with enum value descriptions.
- ▌ Injection · kubernetes-sigs-kueueFlag injection vectors from user-supplied strings — exec, SSRF, fmt.Sprintf-built selectors/URLs, template rendering, query concatenation (CWE-78, CWE-94, CWE-918).
- ▌ Kueue E2e Cluster Multikueue · kubernetes-sigs-kueueCreate (or reuse) the manager + worker kind clusters for Kueue MultiKueue e2e development. Use when a user asks to spin up MultiKueue e2e clusters, get a local multi-cluster environment ready, or debug/iterate against a MultiKueue e2e suite (baseline, extended, sequential, DRA).
- ▌ Kueue E2e Cluster Singlecluster · kubernetes-sigs-kueueCreate (or reuse) a single kind cluster for Kueue e2e development. Use when a user asks to spin up an e2e cluster, get a local kind environment ready for e2e tests, or debug/iterate against a single-cluster e2e suite (baseline, extended, sequential, TAS, cert-manager, DRA).
- ▌ Architectural Decisions · kubernetes-sigs-kueueReview a diff for small-scale structural problems — unjustified complexity, duplicated logic, scope creep, or misplaced code.
- ▌ Imprecise Names · kubernetes-sigs-kueueFlag identifiers whose name does not describe exactly what they contain — drift from package patterns, contradictory contents, misnamed feature gates, asymmetric mirror fields.